Fix urllib3 2.0 compatibility #3117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inheriting from `urllib3.connection.HTTPConnection` (that inherits from `httplib.HTTPConnection` itself), we can adapt to the internal changes in urllib3 2.0 that added a `request()` method that is incompatible with `httplib.HTTPConnection.request`. Signed-off-by: Quentin Pradet <quentin.pradet@gmail.com>
pquentin
force-pushed
the
urllib3-2.0-compatibility
branch
from
fc74d71
to
fdf9fa8
Compare
|
Closing in favor of #3116 |
This was referenced May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By inheriting from
urllib3.connection.HTTPConnection(that inherits fromhttplib.HTTPConnectionitself), we can adapt to the internal changes in urllib3 2.0 that added arequest()method that is incompatible withhttplib.HTTPConnection.request.See #3113 (comment) for details.