fix: Make source a keyword argument for Mounts #3143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is no source for tmpfs mounts. * Raise an exception if a source hasn't been parsed for types other than tmpfs. Signed-off-by: Jack Dane <jackd98.jd@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Okay, I looked at this more after the unit test failures. Empty As a result, I'm closing this PR, but let me know if you have questions or there's a case that still isn't supported. I gave an example on #3139 which might be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.docker.com/storage/tmpfs/
There is the possibility to make the keyword argument an empty string as it should raise an error anyway when needed for certain types of mounts, but I think this error is easier to understand + is similar to the implementation already.
fixes #3139