Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify Host Devices during container start #373

Merged
merged 1 commit into from
Oct 29, 2014
Merged

Ability to specify Host Devices during container start #373

merged 1 commit into from
Oct 29, 2014

Conversation

dims
Copy link
Contributor

@dims dims commented Oct 24, 2014

The command line and daemon started supporting --device
parameter during docker start a while ago in the following commit:
moby/moby@e855c4b

Since the command line looks like this,
--device=[] Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc)
This patch allows a list of strings to be passed into the start() method
and we parse out the 3 components just like in the above mentioned commit

@shin-
Copy link
Contributor

shin- commented Oct 24, 2014

Looks good, can you

  1. Add the missing newline at the end of the utils.py file
  2. Add some documentation to the README file explaining what format is expected for the devices param, similar to this section

Thanks!

The command line and daemon started supporting --device
parameter during docker start a while ago in the following commit:
moby/moby@e855c4b

Since the command line looks like this,
--device=[] Add a host device to the container (e.g. --device=/dev/sdc:/dev/xvdc)
This patch allows a list of strings to be passed into the start() method
and we parse out the 3 components just like in the above mentioned commit
@dims
Copy link
Contributor Author

dims commented Oct 27, 2014

@shin- I've addressed the 2 suggestions, can you please take alook when you get a chance?

@shin- shin- merged commit 7a917cc into docker:master Oct 29, 2014
@shin-
Copy link
Contributor

shin- commented Oct 29, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants