Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example to the lxc_conf argument in the start command #81

Merged
merged 1 commit into from
Nov 7, 2013

Conversation

ureyes84
Copy link
Contributor

@ureyes84 ureyes84 commented Nov 6, 2013

Clarifies documentation for the lxc_conf argument in the start command. The documentation says the parameter is a dict; however, it requires a specific syntax such as:

[{"Key":"lxc.cgroup.cpu.shares","Value":"1"}, {"Key": ..., "Value": }]`

Related to #79

@denibertovic
Copy link
Contributor

@ureyes84 you should disable the autotrim feature of your editor for markdown files. The spaces at the end of the lines are actually required for new lines (I did this not so long ago XD)

This needs correcting but other than that it looks fine.

@ureyes84
Copy link
Contributor Author

ureyes84 commented Nov 7, 2013

@denibertovic Sorry about that :) I've updated the pull request.

@denibertovic
Copy link
Contributor

LGTM!

@shin-
Copy link
Contributor

shin- commented Nov 7, 2013

Thanks, I'll merge this. In the long run it would probably be a good idea to make the whole thing less tedious (by allowing input like {"lxc.cgroup.cpu.shares":"1"} (I'll create an issue)

shin- added a commit that referenced this pull request Nov 7, 2013
Added example to the lxc_conf argument in the start command
@shin- shin- merged commit 4b8938a into docker:master Nov 7, 2013
@shin- shin- mentioned this pull request Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants