Pass stdin data on attach #946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intrepidlemon
force-pushed
the
stdin-on-attach
branch
from
2e8d607
to
7ae471d
Compare
intrepidlemon
force-pushed
the
stdin-on-attach
branch
from
7e25de8
to
36dad87
Compare
intrepidlemon
force-pushed
the
stdin-on-attach
branch
from
36dad87
to
7ae471d
Compare
Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> send stdin string through underlying socket of post response Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> add unit tests for attach Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> adhere to flake8 linting and modify stdin to work with python3 Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> add documentation for stdin Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> remove redundant variable Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com> rename variables for consistency Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com>
intrepidlemon
force-pushed
the
stdin-on-attach
branch
from
c21299d
to
16cecd7
Compare
Signed-off-by: Ianto Lin Xi <iantolinxi@gmail.com>
intrepidlemon
force-pushed
the
stdin-on-attach
branch
from
16cecd7
to
dbe435b
Compare
|
I commented in #239 about a workaround for Python 3 that was brought up by @slix. While I would like an easier way to pass something into stdin upon creation of a container, i think the workaround is actually the right way to go about it if you want to keep your container running and accept more stdin input. |
|
This would be great, but unfortunately we've had a pretty major API change in the development version. Would you mind rebasing, @intrepidlemon? |
|
cleanup |
|
@bfirsh so it seems all progress on getting an interactive container has stopped? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no simple way of passing in
stdincontent into an attached container. The implementation provided by #239 did not work for me. This PR adds an additional parameter where one can pass in string or byte data to be written into thestdinof an attached container.In addition, this PR also contains:
stdinstdinattach