New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC 2 for in-page TOC #1474

Merged
merged 2 commits into from Feb 2, 2017

Conversation

Projects
None yet
2 participants
@mistyhacks
Contributor

mistyhacks commented Feb 2, 2017

Proposed changes

This approach is fully liquid. You can configure with:

  • no_toc: true
  • toc_min: 2
  • toc_max: 6

The site defaults are 2 and 3 for the min and max.

This retains the Edit / Request / Support links on the side, as well.

@londoncalling
Contributor

londoncalling left a comment

I like it.

@mistyhacks mistyhacks force-pushed the mistyhacks:auto_toc_inpage2 branch 7 times, most recently from d8d09ba to eb3c38f Feb 2, 2017

@mistyhacks

This comment has been minimized.

Contributor

mistyhacks commented Feb 2, 2017

Had to give up on that last commit for now. At least the JS is getting an overhaul!

@mistyhacks

This comment has been minimized.

Contributor

mistyhacks commented Feb 2, 2017

This is ready to merge! Thanks @allejo for all of the help in the implementation!

@mistyhacks mistyhacks merged commit 2a88caa into docker:master Feb 2, 2017

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
deploy/netlify Deploy preview ready!
Details

@mistyhacks mistyhacks deleted the mistyhacks:auto_toc_inpage2 branch Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment