Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwards compatibility of client API #28895

Closed
ndegory opened this issue Nov 28, 2016 · 1 comment
Closed

backwards compatibility of client API #28895

ndegory opened this issue Nov 28, 2016 · 1 comment
Assignees
Labels
area/api kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed.
Milestone

Comments

@ndegory
Copy link

ndegory commented Nov 28, 2016

Description

The Docker client API from tag v1.13.0-rc2 breaks the ImageList API when used with a Docker server below 1.25.

Steps to reproduce the issue:

  1. Create a client with version 1.24: client := NewClient(socket, "1.24", nil, header))
  2. Build an ImageListOptions object with a reference filter (replaces the MatchName property from previous versions of the API):
    filter := filters.NewArgs()
    filter.Add("reference", imageName)
    options := types.ImageListOptions{All: false, Filters: filter}
  1. Use the ImageList object with these options: list, err := client.ImageList(ctx, options)
  2. Test the client against a 1.12.3 Docker engine

Describe the results you received:

The Docker engine complains about an unknown filter:
Error response from daemon: Invalid filter 'reference'

Describe the results you expected:

The API should adapt (based on the version passed to NewClient) and provide the proper parameters to the server.

@vdemeester vdemeester self-assigned this Nov 28, 2016
@vdemeester vdemeester added area/api kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. labels Nov 28, 2016
@vdemeester vdemeester added this to the 1.13.0 milestone Nov 28, 2016
@vdemeester
Copy link
Member

@ndegory true 😓 working on fixing it for next RC 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed.
Projects
None yet
Development

No branches or pull requests

2 participants