-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict allowed characters in container names #3138
Comments
@aanand What would you like to see added to |
I quite like the idea of app name restrictions being consistent with images and users (i.e. |
What @bfirsh said seems reasonable to me. +1. |
OK, if there's already a standard restriction in place for images and users, doing the same for container names sounds sensible. |
creack
added a commit
that referenced
this issue
Dec 14, 2013
Validate container names on creation. Fixes #3138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While it’s cool that I can start a container named ‘☃’, ‘▀ ▁ ▂ ▃ ▄ ▅ ▆ ▇ █ ▉ ▊ ▋ ▌ ▍ ▎ ▏ ▐ ░ ▒ ▓ ▔ ▕’ or ‘ " # $ % & ' ( ) * + , - . / 0 1 2 3 4 5 6 7 8 9 : ; < = > ? @ A B C D E F G H I J K L M N O P Q R S T U V W X Y Z [ \ ] ^ _ ` a b c d e f g h i j k l m n o p q r s t u v w x y z { | } ~ 。 「 」 、 ・’, I'm not convinced it's adding that much value.
After five minutes messing around,
/
is the one character I've found which does actually cause an error (presumably because it's used as a path separator), so that should definitely be disallowed.Beyond that, I don't necessarily think Docker should go as far as to only allow, say,
a-zA-Z0-9_
(which feels arbitrarily Western-centric, among other things), but the current level of permissiveness feels to me like a bunch of errors waiting to happen.The text was updated successfully, but these errors were encountered: