Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run validation scripts using only Docker remote API dependency #31673

Closed
tonistiigi opened this issue Mar 9, 2017 · 9 comments
Closed
Assignees

Comments

@tonistiigi
Copy link
Member

make validate
...
fatal: Not a git repository (or any of the parent directories): .git
make: *** [validate] Error 128

@vdemeester @thaJeztah

@vdemeester
Copy link
Member

hum it shouldn't happen with make 😱 … I'll take a look

@vdemeester vdemeester self-assigned this Mar 9, 2017
@vdemeester
Copy link
Member

@tonistiigi when does this happen ? (on master I can't reproduce 😓)

@vdemeester
Copy link
Member

it can happen if you're targeting a remote daemon though (as it bind-mount the .git folder for validate)

@tonistiigi
Copy link
Member Author

@vdemeester Yes, that's what I meant by "only Docker remote API".

@vdemeester
Copy link
Member

ahah, didn't read correctly the title of the issue 😅

@tonistiigi
Copy link
Member Author

@vdemeester Why was this closed?

@vdemeester
Copy link
Member

I don't think we're going to fix that in the near future (and with the moby split, etc..) I feel this going to be fixed another way.

I'm ok to re-open and wait for something like https://forums.mobyproject.org/t/proposal-split-containerize-hack-validate/32 fixing it though 😉

@tonistiigi
Copy link
Member Author

I'm not sure how https://forums.mobyproject.org/t/proposal-split-containerize-hack-validate/32 could fix it as it uses volumes as well(at least for the syntax proposed, validator image itself could probably be used without them as well).

@vdemeester
Copy link
Member

Hum right… what I meant is that with the split into each components, each one will handle this on their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants