[24.0 backport] Dockerfile: Windows: update Golang download domains to cut down redirects #46325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documentation moved to a different page, and the Go documentation moved to the https://go.dev/ domain. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2aabd64) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…ects
The `golang.org` domain moved to `go.dev`, and the download-URLs we were
using resulted in 2 redirects;
curl -sI https://golang.org/dl/go1.20.windows-amd64.zip | grep 'location'
location: https://go.dev/dl/go1.20.windows-amd64.zip
curl -sI https://go.dev/dl/go1.20.windows-amd64.zip | grep 'location'
location: https://dl.google.com/go/go1.20.windows-amd64.zip
curl -sI https://dl.google.com/go/go1.20.windows-amd64.zip
HTTP/2 200
# ...
This patch cuts it down to one redirects. I decided not to use the "final"
(`dl.google.com`) URL, because that URL is not documented in the Golang docs,
and visiting the domain itself (https://dl.google.com/) redirects to a marketing
page for "Google Chrome".
Trying the `/go/` path (https://dl.google.com/go/) also does not show a landing
page that lists downloads, so I'm considering those URLs to be "unstable".
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit f6a5318)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vvoland
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hack: update link to GOPATH documentation
This documentation moved to a different page, and the Go documentation
moved to the https://go.dev/ domain.
Dockerfile: Windows: update Golang download domains to cut down redirects
The
golang.orgdomain moved togo.dev, and the download-URLs we wereusing resulted in 2 redirects;
This patch cuts it down to one redirects. I decided not to use the "final"
(
dl.google.com) URL, because that URL is not documented in the Golang docs,and visiting the domain itself (https://dl.google.com/) redirects to a marketing
page for "Google Chrome".
Trying the
/go/path (https://dl.google.com/go/) also does not show a landingpage that lists downloads, so I'm considering those URLs to be "unstable".
- A picture of a cute animal (not mandatory but encouraged)