New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPFS filesystem IDs #19216
Add GPFS filesystem IDs #19216
Conversation
Can you squash, and sign off your commits? Otherwise we won't be able to review your PR, thanks! |
I will, please give me few days to set things up. |
ping @scaleoutsean just a friendly reminder 😄 |
I hope this will do. |
I think you need to rebase, because there's a non-related commit in this pr now 😢 |
@scaleoutsean I think you are an IBMer--if you need help with this reach out to myself or @duglin and I'm sure we can help you get this sorted out! |
Thanks @thaJeztah and @estesp, I was traveling and didn't have time to attend to this. |
LGTM |
ping @estesp for the merge |
LGTM |
@estesp @scaleoutsean does IBM need this change for docker 1.10? Looks like a simple change, so probably safe to cherry-pick, but just asking (otherwise it'll be in 1.11) |
I can't speak for the company, but from my personal perspective it'd be nice to have it sooner because it makes Docker on this filesystem slightly easier to manage (when one sees the underlying filesystem is recognized and of particular type, rather than just unknown). |
Alright, well basically it's a bug (docker doesn't recognize GPFS filesystem) 😉 so, let's mark it for cherry-picking |
No description provided.