Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPFS filesystem IDs #19216

Merged
merged 1 commit into from Jan 23, 2016
Merged

Add GPFS filesystem IDs #19216

merged 1 commit into from Jan 23, 2016

Conversation

scaleoutsean
Copy link
Contributor

No description provided.

@GordonTheTurtle GordonTheTurtle added status/0-triage dco/no Automatically set by a bot when one of the commits lacks proper signature labels Jan 10, 2016
@thaJeztah
Copy link
Member

Can you squash, and sign off your commits? Otherwise we won't be able to review your PR, thanks!

@scaleoutsean
Copy link
Contributor Author

I will, please give me few days to set things up.

@thaJeztah
Copy link
Member

ping @scaleoutsean just a friendly reminder 😄

@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jan 17, 2016
@scaleoutsean
Copy link
Contributor Author

I hope this will do.
The instructions don't seem to work exactly to the letter. I hadn't used git client to begin with, so I downloaded my fork and messed around with it until it appeared to do something. Don't know if that other issue (#18282) is supposed to appear in my PR, but it gets added automatically after git rebase -i HEAD~2 so I assumed that's how it should be.

@thaJeztah
Copy link
Member

I think you need to rebase, because there's a non-related commit in this pr now 😢

@estesp
Copy link
Contributor

estesp commented Jan 21, 2016

@scaleoutsean I think you are an IBMer--if you need help with this reach out to myself or @duglin and I'm sure we can help you get this sorted out!

Signed-off-by: Sean Lee <seanlee@tw.ibm.com>
@scaleoutsean
Copy link
Contributor Author

Thanks @thaJeztah and @estesp, I was traveling and didn't have time to attend to this.

@thaJeztah
Copy link
Member

LGTM

@thaJeztah
Copy link
Member

ping @estesp for the merge

@estesp
Copy link
Contributor

estesp commented Jan 23, 2016

LGTM

estesp added a commit that referenced this pull request Jan 23, 2016
@estesp estesp merged commit 67d86d1 into moby:master Jan 23, 2016
@thaJeztah
Copy link
Member

@estesp @scaleoutsean does IBM need this change for docker 1.10? Looks like a simple change, so probably safe to cherry-pick, but just asking (otherwise it'll be in 1.11)

@scaleoutsean
Copy link
Contributor Author

I can't speak for the company, but from my personal perspective it'd be nice to have it sooner because it makes Docker on this filesystem slightly easier to manage (when one sees the underlying filesystem is recognized and of particular type, rather than just unknown).

@thaJeztah
Copy link
Member

Alright, well basically it's a bug (docker doesn't recognize GPFS filesystem) 😉 so, let's mark it for cherry-picking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants