Clear old parent reference on resetting image parent #20058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On migration 2 different images can end up with same content addressable ID, meaning `SetParent` will be called multiple times. Previous version did not clear the old in-memory reference. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
LGTM if tests pass |
|
LGTM |
runcom
added a commit
that referenced
this pull request
Feb 6, 2016
Clear old parent reference on resetting image parent
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Feb 10, 2016
On migration 2 different images can end up with same content addressable ID, meaning `SetParent` will be called multiple times. Previous version did not clear the old in-memory reference. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 4852932) From PR moby#20058
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On migration 2 different images can end up with same
content addressable ID, meaning
SetParentwill be calledmultiple times. Previous version did not clear the old
in-memory reference.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com