return status code http.StatusNoContent in deleting network when OK #20977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
force-pushed
the
fix-delete-response-status-code
branch
from
a9f4f8f
to
4562a21
Compare
|
This would need an update to the API docs. ping @mavenugo |
…ccessful 2.modify docker_api_network_test.go 3.modify docker_remote_api_v1.23.md Signed-off-by: allencloud <allen.sun@daocloud.io>
allencloud
force-pushed
the
fix-delete-response-status-code
branch
from
4562a21
to
94c9290
Compare
|
@cpuguy83 |
|
@cpuguy83 And may I ask the relationship of docker api version and docker version? |
|
No need to modify the API for the current released version since we will not change that. There's a chart in the docs relating API version to release version. |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Mar 13, 2016
…code return status code http.StatusNoContent in deleting network when OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.return status code http.StatusNoContent in deleting network when successful
2.modify docker_api_network_test.go
fixes #20976