Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Go 1.5.3. #21489

Merged
merged 1 commit into from Mar 25, 2016
Merged

Downgrade to Go 1.5.3. #21489

merged 1 commit into from Mar 25, 2016

Conversation

calavera
Copy link
Contributor

To not hit the issue with the request Host header.

Fixes #20865

Signed-off-by: David Calavera david.calavera@gmail.com

@crosbymichael
Copy link
Contributor

LGTM

@calavera calavera force-pushed the downgrade_go branch 2 times, most recently from e58fd87 to 485d61a Compare March 24, 2016 23:02
To not hit the issue with the request Host header.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@icecrime
Copy link
Contributor

LGTM

@calavera
Copy link
Contributor Author

Is this a flacky error on experimental, or different Go versions output different messages?

00:02:50 FAIL: docker_experimental_network_test.go:326: DockerNetworkSuite.TestDockerNetworkIpvlanAddressing
00:02:50 
00:02:50 docker_experimental_network_test.go:340:
00:02:50     c.Assert(out, checker.Contains, "default via 2001:db8:abca::254 dev eth0")
00:02:50 ... obtained string = "" +
00:02:50 ...     "fe80::/64 dev eth0  metric 256 \n" +
00:02:50 ...     "unreachable default dev lo  metric -1  error -101\n" +
00:02:50 ...     "ff00::/8 dev eth0  metric 256 \n" +
00:02:50 ...     "unreachable default dev lo  metric -1  error -101\n"
00:02:50 ... substring string = "default via 2001:db8:abca::254 dev eth0"

@calavera
Copy link
Contributor Author

it looks like it was

@thaJeztah
Copy link
Member

Test will be fixed by #21492, and only fails on kernel 4.2+

@estesp
Copy link
Contributor

estesp commented Mar 25, 2016

Probably needs to be a follow-on PR for Dockerfile.ppc64le since it was switched to use native Go compiler, which exists in 1.6, but not 1.5.3. So, it will have to go back to gccgo I guess.

@thaJeztah
Copy link
Member

Good catch, @estesp

@thaJeztah
Copy link
Member

I checked, and I think all 1.6 references are covered here

@icecrime
Copy link
Contributor

I triggered an arm build: let's wait for this one to complete before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants