Fix & improve bash completion for swarm mode commands #24119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
added
the
priority/P3
|
ping @mgoelzer @tianon PTAL |
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
Signed-off-by: Harald Albers <github@albersweb.de>
albers
force-pushed
the
completion-swarm-mode
branch
from
7dbcfd2
to
009d50e
Compare
|
Updated for the renamed filter |
|
Woohoo, thank you! 👍 LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #23363, #23476
fixes
docker service {ls,tasks} --filterwas treated as a boolean optiondocker node demotewould also complete files in the current directorynew completions
docker {service,node} {ls,tasks}docker swarm init hostname:and--listen-addr hostname:cleanup
There was duplicated logic in quite a bunch of helper funcions for service and node lookups.
This was refactored into two parameterized functions that now also deal with customization, see next item.
configurable completions
For images and networks we already have environment variables that configure whether or not IDs should be used in completions. Now, you can configure this for services and nodes as well.
Please schedule for 1.12.0
ping @jfrazelle @tianon for review
ping @sdurrheimer Hi, maybe you can use this in zsh completion