Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Clear volume path for Hyper-V containers #24156

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

lowenna
Copy link
Member

@lowenna lowenna commented Jun 29, 2016

Signed-off-by: John Howard jhoward@microsoft.com

Found internally, the following sequence was failing on the start. This probably should meet the 1.12 bar for cherry-picking.

docker run --isolation=hyperv --name test nanoserver ipconfig
docker commit test blah
docker start test

Fixes internal bug 8035051.

Note writing a regression test is not possible currently as it only affects Hyper-V containers, and it's not possible to run anything except Windows Server containers under the current CI infrastructure.

@swernli.

Signed-off-by: John Howard <jhoward@microsoft.com>
@swernli
Copy link
Contributor

swernli commented Jun 29, 2016

LGTM

@lowenna lowenna changed the title Windows: Clear container basefs on unmount Windows: Clear volume path for Hyper-V containers Jun 30, 2016
@lowenna
Copy link
Member Author

lowenna commented Jul 6, 2016

@thaJeztah Falling down a black hole....

@thaJeztah
Copy link
Member

oh, so sorry

LGTM - can you add milestone and cherry pick label? I'm typing on my phone

ping @cpuguy83 @tiborvass PTAL

@tiborvass
Copy link
Contributor

LGTM

@tiborvass tiborvass added this to the 1.12.0 milestone Jul 7, 2016
@tiborvass tiborvass merged commit efcf24f into moby:master Jul 7, 2016
@lowenna lowenna deleted the jjh/clearbasefs branch July 7, 2016 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants