Fixed a few network UI issues in swarm-mode #24158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Detect name conflicts on network creation * Detect and prevent network connect/disconnect for managed containers Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
Are we sure we want to introduce a concept of "managed" and "unmanaged" containers? How does this resolve creating a local network named "test", if there's an overlay network with the same name? |
|
@thaJeztah we have a few cases where we have to differentiate managed and unmanaged containers (mostly due to the current limitations that we have with a few unsupported features). When we are feature parity, then we can relax these restrictions and maybe remove this differentiation as well.
That's exactly this PR does with the changes in api/server/router/network/network_routes.go. |
|
LGTM |
|
LGTM 🐸 |
icecrime
added
status/4-merge
process/cherry-pick
and removed
status/2-code-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker network create -d bridge testworks if there is already an overlay network named test? #23983