Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #24281

Merged
merged 1 commit into from
Jul 3, 2016
Merged

Fix typo #24281

merged 1 commit into from
Jul 3, 2016

Conversation

aochagavia
Copy link
Contributor

No description provided.

@GordonTheTurtle GordonTheTurtle added status/3-docs-review dco/no Automatically set by a bot when one of the commits lacks proper signature labels Jul 3, 2016
@aochagavia
Copy link
Contributor Author

I see you need to sign the commits, but I have no time to do it now (I would have to investigate how to do that on Windows). Feel free to treat this PR as an issue.

@duglin
Copy link
Contributor

duglin commented Jul 3, 2016

just add -s to your git commit command, and make sure you have the git config properties user.name and user.email set.

@aochagavia
Fix typo
76b09be 
Signed-off-by: Adolfo Ochagavía <aochagavia92@gmail.com>
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jul 3, 2016
@aochagavia
Copy link
Contributor Author

Done. Thanks! I didn't expect it to be that easy 😄

@runcom
Copy link
Member

runcom commented Jul 3, 2016

LGTM

1 similar comment
@duglin
Copy link
Contributor

duglin commented Jul 3, 2016

LGTM

@duglin duglin merged commit e64a691 into moby:master Jul 3, 2016
@aochagavia aochagavia deleted the patch-1 branch July 3, 2016 13:32
@tiborvass tiborvass mentioned this pull request Jul 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
process/cherry-picked status/3-docs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aochagavia @duglin @runcom @tiborvass @thaJeztah @GordonTheTurtle