Add fchmod and fchmodat to TestRunSeccompProfileDenyChmod #24299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I noticed this in another PR that was adding a similar test, will try to find it too. |
|
The Windows test failure is unrelated. |
Signed-off-by: Lei Jitang <leijitang@huawei.com>
|
LGTM |
|
I think we should cherry pick this for rc as there is a possibility that at some point the system call used might change elsewhere and start breaking tests. |
8 tasks
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
cherry-picked from upstream moby#24299 Signed-off-by: Lei Jitang <leijitang@huawei.com> Signed-off-by: Fengtu Wang <wangfengtu@huawei.com>
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
Add fchmod and fchmodat to TestRunSeccompProfileDenyChmod cherry-picked from upstream moby#24299 Signed-off-by: Lei Jitang <leijitang@huawei.com> Signed-off-by: Fengtu Wang <wangfengtu@huawei.com> See merge request docker/docker!652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
On arm64, chmod binary use syscall fchmodat, strace shows:
this will make test TestRunSeccompProfileDenyChmod on arm64 failed.
there are three syscall
chmodfchmodandfchmodatto change the permissions of a file,I think it's better to add all to this test.
ping @jfrazelle @justincormack
Signed-off-by: Lei Jitang leijitang@huawei.com