Add NoArm64 testRequires and skip Schema1RegistrySuite on arm64 #24300
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Should any of the other tests that are marked as not ppc64le etc also be marked as not arm64? |
|
@justincormack I haven't run the integration test with the master on arm64, we run the integration test with 1.11.1 and we only found |
|
Ok, well we can add them later if they turn up. I may be able to do some testing too, I did some light testing a few weeks back. |
schema1 manifests is not working on ARM64, we should skip integration-cli tests for schema1 manifests on ARM64. Signed-off-by: Lei Jitang <leijitang@huawei.com>
|
LGTM |
|
ping @vdemeester |
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
schema1 manifests is not working on ARM64, we should skip integration-cli tests for schema1 manifests on ARM64. cherry-picked from upstream moby#24300 Signed-off-by: Lei Jitang <leijitang@huawei.com> Signed-off-by: Fengtu Wang <wangfengtu@huawei.com>
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
Add NoArm64 testRequires and skip Schema1RegistrySuite on arm64 schema1 manifests is not working on ARM64, we should skip integration-cli tests for schema1 manifests on ARM64. cherry-picked from upstream moby#24300 Signed-off-by: Lei Jitang <leijitang@huawei.com> Signed-off-by: Fengtu Wang <wangfengtu@huawei.com> See merge request docker/docker!651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
schema1 manifests is not working on ARM64, we should skip integration-cli
tests for schema1 manifests on ARM64.
https://github.com/docker/docker/blob/master/Dockerfile.aarch64#L108
Signed-off-by: Lei Jitang leijitang@huawei.com