Remove unmatched bracket from _docker for zsh #24373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonTheTurtle
added
status/3-docs-review
dco/no
floatingLomas
force-pushed
the
zsh-completion-fix
branch
from
e17319f
to
f996b38
Compare
GordonTheTurtle
removed
the
dco/no
floatingLomas
force-pushed
the
zsh-completion-fix
branch
from
f996b38
to
7631dc8
Compare
Signed-off-by: Jonathan Lomas <jonathan@floatinglomas.ca>
|
LGTM ping @sdurrheimer |
|
looks good to me, its just removing an extra ")" |
|
LGTM |
|
@floatingLomas Thanks, I did notice a problem with completion, but haven't got the time to look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a dangling ')' in the zsh _docker completion script.
- How I did it
...With my keyboard?
- How to verify it
tab completion no longer explodes with a parse error in zsh.
- Description for the changelog
Fixed a zsh tab completion issue.
- A picture of a cute animal (not mandatory but encouraged)
