Detect non-plugin content during install and error out. #24383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,9 @@ import "errors" | |||
| // ErrUnSupportedRegistry indicates that the registry does not support v2 protocol | |||
| var ErrUnSupportedRegistry = errors.New("Only V2 repositories are supported for plugin distribution") | |||
|
|
|||
| // ErrUnSupportedMediaType indicates we are pulling content that's not a plugin | |||
| var ErrUnSupportedMediaType = errors.New("Content is not a plugin") | |||
There was a problem hiding this comment.
nit: Unsupported instead of UnSupported.
Also, error text should be lowercase.
|
LGTM |
|
LGTM 🐹 with @aaronlehmann comment addressed 👼 |
anusha-ragunathan
force-pushed
the
not-plugin
branch
from
f2dac93
to
3f1f0ad
Compare
Signed-off-by: Anusha Ragunathan <anusha@docker.com>
anusha-ragunathan
force-pushed
the
not-plugin
branch
from
3f1f0ad
to
d32df6d
Compare
|
nit was adresses; LGTM |
thaJeztah
added
status/4-merge
process/cherry-pick
and removed
status/2-code-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anusha Ragunathan anusha@docker.com