-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes broken link in docs. #24471
Fixes broken link in docs. #24471
Conversation
d3fac11
to
854da25
Compare
I think when |
yes, its horrible that we've released broken documentation for a release that hasn't happened yet :( unfortunately, the docs tooling expects there should be no broken links - and we've finally fixed enough that these are standing out like sore thumbs. The other option, is to defuse the links (ie, put |
@joaofnfernandes @thaJeztah what if we set the links to https://github.com/docker/docker/releases/ for now, and someone promises to fix it when 1.12.0 actually happens? |
Fixes moby#24428 Signed-off-by: Joao Fernandes <joao.fernandes@docker.com>
854da25
to
6c9b5da
Compare
I've changed the link to point to https://github.com/docker/docker/releases/. In my opinion if we decide to link to something, we need to ensure that page exists, otherwise we're providing a bad user experience. |
Alright, let's go for this, given that we remove it before GA LGTM |
Fixes #24428