Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken link in docs. #24471

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Conversation

joaofnfernandes
Copy link
Contributor

Fixes #24428

@GordonTheTurtle GordonTheTurtle added status/3-docs-review dco/no Automatically set by a bot when one of the commits lacks proper signature labels Jul 8, 2016
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jul 8, 2016
@yongtang
Copy link
Member

yongtang commented Jul 8, 2016

I think when 1.12.0 is formally released, we want to have the link pointing to 1.12.0 not 1.12.0-rc3. So there might be a chicken and egg issue here. We probably need to change back to 1.12.0 just before the 1.12.0 release (or cherry pick the change).

@SvenDowideit
Copy link
Contributor

yes, its horrible that we've released broken documentation for a release that hasn't happened yet :(

unfortunately, the docs tooling expects there should be no broken links - and we've finally fixed enough that these are standing out like sore thumbs.

The other option, is to defuse the links (ie, put backtics around them)

@SvenDowideit
Copy link
Contributor

@joaofnfernandes @thaJeztah what if we set the links to https://github.com/docker/docker/releases/ for now, and someone promises to fix it when 1.12.0 actually happens?

Fixes moby#24428

Signed-off-by: Joao Fernandes <joao.fernandes@docker.com>
@joaofnfernandes
Copy link
Contributor Author

I've changed the link to point to https://github.com/docker/docker/releases/.

In my opinion if we decide to link to something, we need to ensure that page exists, otherwise we're providing a bad user experience.
The other option is not linking, which also works.

@thaJeztah
Copy link
Member

Alright, let's go for this, given that we remove it before GA

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants