swarmkit expects network-id for as target #24474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For any operation that involves netwoks (other than network create), swarmkit expects the target as network-id. Service upate was using network-name as the target and that caused the issue. Signed-off-by: Madhu Venugopal <madhu@docker.com>
vdemeester
added
status/2-code-review
area/networking
area/swarm
and removed
status/0-triage
labels
|
LGTM |
|
LGTM 🐮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any operation that involves netwoks (other than network create),
swarmkit expects the target as network-id. Service update was using
network-name as the target and that caused #24452
Fixes #24452
Signed-off-by: Madhu Venugopal madhu@docker.com