Remove execution driver #24501
Merged
Remove execution driver #24501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use containerd and there is no execution driver anymore. Addresses: moby#24461 Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
|
Engine-api change is in docker/engine-api#309 |
|
/cc @mlaventure |
|
LGTM (IANAM). This was an omission from #20662 Funny it took so long to find. /cc @tonistiigi |
|
LGTM 🐸. Should be put this into |
|
I think adding it would be ok; quick check with @tiborvass if he's okay with it too |
|
LGTM |
|
Needs an update to api 1.24 since it gets cherrypicked. |
|
created a PR to fix the docs; #24560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
We use containerd and there is no execution driver anymore.
Addresses: #24461
Signed-off-by: Qiang Huang h.huangqiang@huawei.com