Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --network option for docker build #27702

Merged
merged 2 commits into from
Oct 26, 2016
Merged

add --network option for docker build #27702

merged 2 commits into from
Oct 26, 2016

Conversation

tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Oct 24, 2016 •
edited by thaJeztah
Loading

carry #20987

fixes #10324

@vdemeester

@thaJeztah thaJeztah added this to the 1.13.0 milestone Oct 24, 2016
@thaJeztah
Copy link
Member

don't forget to update the reference docs, man pages, and API docs + changelog

vdemeester
vdemeester approved these changes Oct 25, 2016
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸
@tonistiigi Ah one question though, should we have a --net hidden flag or not ? (/cc @dnephin @thaJeztah on that question too)

@thaJeztah
Copy link
Member

I don't think we should add --net as alias here. This is a new feature, and there's never been a --net, so no need to add it for backward compatibility. We can add it if there's a lot of requests, but let's keep it simple now

@thaJeztah thaJeztah mentioned this pull request Oct 25, 2016
Closed
@mavenugo
Copy link
Contributor

LGTM

@sandyskies
Copy link
Contributor

I think just --network will be fine.

@cpuguy83
Copy link
Member

Seems to be missing --add-host from the referenced issue.

@cpuguy83
Copy link
Member

But otherwise LGTM so moving to docs-review, we can follow-up with add-host

vdemeester
vdemeester approved these changes Oct 25, 2016
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs LGTM 🐸
/cc @thaJeztah

@thaJeztah
Copy link
Member

Oh, looks like docs are missing for the CLI reference;

And man page;

@icecrime
Copy link
Contributor

Ping @justincormack @vikstrous FYI.

sandyskies and others added 2 commits October 25, 2016 10:25
@sandyskies @tonistiigi
add --network option for docker build
60813af 
Signed-off-by: sandyskies <chenmingjie0828@163.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Add integration tests for build with network opts
e3b48fc 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@vikstrous
Copy link
Contributor

LGTM I don't think this will significantly decrease the reproducibility of builds since we really can't control the network during a build anyway.

thaJeztah
thaJeztah approved these changes Oct 26, 2016
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 62ff3e9 into moby:master Oct 26, 2016
@philtay philtay mentioned this pull request Oct 30, 2016
Closed
@RoelVdP RoelVdP mentioned this pull request Nov 2, 2016
Closed
@RoelVdP
Copy link

RoelVdP commented Nov 8, 2016

How does this fix #10324?

@thaJeztah
Copy link
Member

@RoelVdP it adds --net to docker build

@albers albers mentioned this pull request Nov 12, 2016
Merged
@sdurrheimer sdurrheimer mentioned this pull request Nov 14, 2016
Merged
@ricardobranco777
Copy link

Does it fix #24824?

@RoelVdP
Copy link

RoelVdP commented Nov 15, 2016

@thaJeztah --add-host=[] was not added? If so, please re-open #10324

@artisticcheese artisticcheese mentioned this pull request Dec 23, 2016
Closed
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Jan 16, 2017
@thaJeztah
Add version annotation to various flags added in 1.13
bbbddee 
Pull request moby#27745 added support for the
client to talk to older versions of the daemon. Various flags were added to
docker 1.13 that are not compatible with older daemons.

This PR adds annotations to those flags, so that they are automatically hidden
if the daemon is older than docker 1.13 (API 1.25).

Not all new flags affect the API (some are client-side only). The following
PR's added new flags to docker 1.13 that affect the API;

- moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime`
- moby#27800 / moby#25317 added `--group` / `--group-add` / `--group-rm`
- moby#27702 added `--network` to `docker build`
- moby#25962 added `--attachable` to `docker network create`
- moby#27998 added `--compose-file` to `docker stack deploy`
- moby#22566 added `--stop-timeout` to `docker run` and `docker create`
- moby#26061 added `--init` to `docker run` and `docker create`
- moby#26941 added `--init-path` to `docker run` and `docker create`
- moby#27958 added `--cpus` on `docker run` / `docker create`
- moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create`
- moby#27596 added `--force` to `docker service update`
- moby#27857 added `--hostname` to `docker service create`
- moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update`
- moby#28076 added `--tty` on `docker service create` / `docker service update`
- moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update`
- moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update`

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jan 16, 2017
Merged
@bboreham bboreham mentioned this pull request Feb 22, 2017
Closed
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@thaJeztah
Merge pull request moby#27702 from tonistiigi/net-builder0
70fbc5e 
add --network option for docker build
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@thaJeztah
Merge pull request moby#27702 from tonistiigi/net-builder0
4c4545c 
add --network option for docker build
andrewhsu pushed a commit to docker-archive/docker-ce that referenced this pull request May 19, 2017
@thaJeztah
Add version annotation to various flags added in 1.13
1daa5da 
Pull request moby/moby#27745 added support for the
client to talk to older versions of the daemon. Various flags were added to
docker 1.13 that are not compatible with older daemons.

This PR adds annotations to those flags, so that they are automatically hidden
if the daemon is older than docker 1.13 (API 1.25).

Not all new flags affect the API (some are client-side only). The following
PR's added new flags to docker 1.13 that affect the API;

- moby/moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime`
- moby/moby#27800 / moby/moby#25317 added `--group` / `--group-add` / `--group-rm`
- moby/moby#27702 added `--network` to `docker build`
- moby/moby#25962 added `--attachable` to `docker network create`
- moby/moby#27998 added `--compose-file` to `docker stack deploy`
- moby/moby#22566 added `--stop-timeout` to `docker run` and `docker create`
- moby/moby#26061 added `--init` to `docker run` and `docker create`
- moby/moby#26941 added `--init-path` to `docker run` and `docker create`
- moby/moby#27958 added `--cpus` on `docker run` / `docker create`
- moby/moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create`
- moby/moby#27596 added `--force` to `docker service update`
- moby/moby#27857 added `--hostname` to `docker service create`
- moby/moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update`
- moby/moby#28076 added `--tty` on `docker service create` / `docker service update`
- moby/moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update`
- moby/moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update`

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 5d2722f83db9e301c6dcbe1c562c2051a52905db
Component: cli
@sanimej sanimej mentioned this pull request Jul 3, 2017
Closed
runcom added a commit to projectatomic/docker that referenced this pull request Aug 31, 2017
@runcom
add --network option for docker build
059451e 
Upstream reference: moby#27702
Fix Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1486809

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@TheWolfNL TheWolfNL mentioned this pull request Sep 4, 2017
Closed
@thaJeztah thaJeztah mentioned this pull request Jan 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
impact/changelog impact/cli impact/documentation status/3-docs-review
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Please add --add-host=[], --net options to docker build