Add tests for ID-based docker plugin enable/disable/rm/set
#29222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
28789-plugin-inspect-follow-up
branch
2 times, most recently
from
da0612e
to
336af27
Compare
|
/cc @tiborvass @vieux |
yongtang
force-pushed
the
28789-plugin-inspect-follow-up
branch
from
336af27
to
4d9ffca
Compare
|
@tonistiigi Thanks. I checked the PR #29487 and verified that it addressed the issue. The following is the test pass on top of #29487: I also rebased this PR so that now it only includes tests. The test for this PR will fail temporarily but should pass once PR #29487 is merged. |
yongtang
force-pushed
the
28789-plugin-inspect-follow-up
branch
from
4d9ffca
to
0f1756f
Compare
yongtang
force-pushed
the
28789-plugin-inspect-follow-up
branch
from
0f1756f
to
3420c6e
Compare
|
@yongtang Needs rebase |
This fix is a follow up based on comment: and a follow up to: moby#29222 (comment) As moby#28789 has been merged in, it is possible for `docker plugin inspect` to search based on Name or ID Prefix. However, ID-based `docker plugin enable/disable/rm/set` are still not possible. This fix addes test for `docker plugin enable/disable/rm/set` to search based on: - Full ID - Full Name - Partial ID (prefix) The actual fix is done in moby#29487. This fix is a follow up of moby#28789 and moby#29487. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
28789-plugin-inspect-follow-up
branch
from
3420c6e
to
c80e74e
Compare
|
Thanks @tonistiigi The PR has been rebased. |
|
LGTM |
thaJeztah
changed the title
docker plugin enable/disable/rm/setdocker plugin enable/disable/rm/set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This fix is a follow up based on comment:
#28789 (comment)
As #28789 has been merged in, it is possible for
docker plugin inspectto search based on Name or ID Prefix. However, ID-baseddocker plugin enable/disable/rm/setare still not possible.- How I did it
This fix allows
docker plugin enable/disable/rm/setto search based on:- How to verify it
An additional integration test has been added to cover the changes. And all existing tests should pass.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
This fix is a follow up of #28789.
/cc @anusha-ragunathan
Signed-off-by: Yong Tang yong.tang.github@outlook.com