Windows: Use sequential file access #30139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstep
approved these changes
Jan 13, 2017
| // and writing, and returns the resulting *os.File. | ||
| // If dir is the empty string, TempFile uses the default directory | ||
| // for temporary files (see os.TempDir). | ||
| // Multiple programs calling TempFile simultaneously |
There was a problem hiding this comment.
Was deliberate - that's the original comment from golang. I put "TempFileSequential" right at the top of the comment
There was a problem hiding this comment.
Yeah, I knew it was copied. It seems slightly confusing here, but no big deal.
| // TempFileSequential is a wrapper around golang ioutil.TempFile which | ||
| // uses file access sequential. | ||
| // | ||
| // TempFile creates a new temporary file in the directory dir |
justincormack
approved these changes
Jan 23, 2017
|
cc @aaronlehmann PTAL |
| } | ||
|
|
||
| // TempFileSequential is a wrapper around golang ioutil.TempFile which | ||
| // uses file access sequential. |
There was a problem hiding this comment.
In this case it's not a wrapper - it's a modified version. Can you clarify this in the comment - I think this will explain a few things that otherwise seem weird, like the use of a hand-rolled PRNG.
There was a problem hiding this comment.
@aaronlehmann Comment updated.
|
SGTM |
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/sequential
branch
from
e0d93ec
to
c98e77c
Compare
|
LGTM |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
Windows: Use sequential file access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
This is a follow-on to #28272 and uses sequential file access in two additional locations. The perf team here have verified this change (and the positive impact). Quoting from an internal mail: "Excellent! The traces look great as well! All the changes and repurposing during export\import happen to low-pri standby, and high priority standby stays intact. In addition to AA improvement, looks like the change further improved commit as well."
Fixes Internal VSO Bug #9900466 @johnstep FYI