Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of client side redirects #425

Closed
aduermael opened this issue Nov 2, 2016 · 5 comments
Closed

Get rid of client side redirects #425

aduermael opened this issue Nov 2, 2016 · 5 comments
Assignees

Comments

@aduermael
Copy link
Contributor

Problem description

Current 404 (not found) page is a 240KB JS script that operates client side redirects.
A 6500 lines script that includes all our redirect rules... This script is built using front-matter aliases and what's in _data/redirects.csv.
This should be handled server side.

Suggestions for a fix

@johndmulhausen suggests that we use redirect_from which Jekyll supports, to generate 301 redirects.

@johndmulhausen
Copy link

#152 is open to test this solution

@thaJeztah
Copy link
Member

reopening GitHub auto-closed this because of an old commit being merged e44f5d8

@thaJeztah thaJeztah reopened this Nov 2, 2016
@aduermael
Copy link
Contributor Author

thank you @thaJeztah!

@johndmulhausen
Copy link

Fixed in 949a89e

joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this issue Nov 11, 2016
- Close docker#194 and fix
- Fix and close docker#425
- Fix and close docker#417
- Fix and close docker#420
- Fix and close docker#422
- Adding in documentation build scripts
- Fix and close docker#431
- Fix and close docker#438, and Fix and close docker#429
- Work on 441
- Adding in commands reference
- Updating all the options to tables
- Updating per Vivek docker#498
- Adding vivek's last suggestions

Signed-off-by: Mary Anthony <mary@docker.com>
@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants