Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for: engine/userguide/networking/work-with-networks.md #96

Closed
bscheshir opened this issue Oct 6, 2016 · 3 comments
Closed
Assignees

Comments

@bscheshir
Copy link
Contributor

URL: engine/userguide/networking/work-with-networks.md

"Let’s try to reach these aliases from container4 (which is connected to both these networks) and container5 (which is connected only to isolated_nw)."
isolated_nw not included container5 now! (docker network disconnect isolated_nw container5)
flip example logic with "local_alias"

@mdlinville
Copy link

Thanks for your feedback. I'll review the docs and make sure the logic is correct.

@mdlinville
Copy link

Hi @bscheshir, thanks again for your feedback on this. As it turns out, it is perfectly fine (and part of the point of the exercise) that container5 doesn't yet exist when you like container4 to it. I've done a pretty big rewrite of this whole topic, and part of that rewrite was to add clarity around that step specifically. You can link to a container which doesn't yet exist, and there are some reasons you might do it. Please have a look at #235 and let me know if that helps. I've asked some developers who are very familiar with Docker networking to review it as well.

I think I've addressed your issue, so I'll close this and we can move any follow-up discussion into the PR. Thanks!

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants