Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites to the 'Working with Networks' topic #235

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Rewrites to the 'Working with Networks' topic #235

merged 1 commit into from
Dec 12, 2016

Conversation

mdlinville
Copy link

Describe the proposed changes

Update 'Working with networks' topic

This was because some confusion was revealed in #96, but it goes beyond the scope of that issue.

  • Verify all the steps, make modifications where necessary
  • Rewrite for grammar and clarity
  • Add explanation for unclear sections
  • Adapt some sections to a stepped tutorial style

Signed-off-by: Misty Stanley-Jones misty@docker.com

Project version

n/a

Related issue

#96

Related issue or PR in another project

n/a

Please take a look

@mrjana @stevvooe

@johndmulhausen
Copy link

@mstanleyjones This is a pretty old PR; can you rebase this to fix merge conflicts and so we get a Netlify preview? I can be of better use as a reviewer then. Also, ping a tech reviewer when you get a chance!

Verify all the steps, make modifications where necessary
Rewrite for grammar and clarity
Add explanation for unclear sections
Adapt some sections to a stepped tutorial style

Signed-off-by: Misty Stanley-Jones <misty@docker.com>
@mdlinville
Copy link
Author

@thaJeztah PTAL, I think you might have looked already (did this start in docker/docker?) This is probably impacted by some of the other rewriting we are working on, but it would be nice to get this one in soon. I think it's a big improvement.

@johndmulhausen rebased and conflicts resolved. Netlify preview should finish shortly.

@johndmulhausen
Copy link

Deploy preview ready!

Built with commit 0fb5e64

https://deploy-preview-235--docker-docs.netlify.com

@mdlinville
Copy link
Author

I've had another look at this topic and I feel pretty good merging it in. I didn't change any facts in the topic, just rewriting / restructuring, and expanding the examples that were there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants