New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Documentation for Swarm Jobs #12037
Conversation
Swarm Jobs were initially implemented in Docker Engine 20.10 Signed-off-by: ollypom <oppomeroy@gmail.com>
✔️ Deploy preview for docsdocker ready! 🔨 Explore the source changes: 9234980 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docsdocker/deploys/6005f3203c85a400075ea66d 😎 Browse the preview: https://deploy-preview-12037--docsdocker.netlify.app |
Thanks @ollypom. @thaJeztah Could you PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arf. Started reviewing this, but didn't manage to finish (wanted to have another look to see what it looks like with my suggestions, but let me submit what I have so far 😓)
Signed-off-by: ollypom <oppomeroy@gmail.com>
Thanks @thaJeztah 😄 I've incorporated your feedback in the latest commit. |
Is there still something blocking the PR from merge? |
Hey @thaJeztah - hate to bug you but it would be awesome if you were able to take another pass at this. Would help a lot of people (including me!) use this functionality thanks to better docs. The code was released in early December 2020 but in my searching for how to do this, it took quite a while to realize it's actually supported in swarm natively and just undocumented. |
A humble ping @thaJeztah would be awesome if we could get this documented and rolling. Also should we have a separate pr for documenting |
Close and reopen PR to trigger build checks |
@usha-mandya Seems like there's some MDL issues and a broken link (htmlproffer) reported by the checks |
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
Proposed changes
Swarm Jobs were initially implemented in Docker Engine 20.10, this PR adds the documentation.
moby/moby#40307