Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Documentation for Swarm Jobs #12037

Closed
wants to merge 2 commits into from
Closed

Added Documentation for Swarm Jobs #12037

wants to merge 2 commits into from

Conversation

ollypom
Copy link
Contributor

@ollypom ollypom commented Jan 4, 2021

Proposed changes

Swarm Jobs were initially implemented in Docker Engine 20.10, this PR adds the documentation.

moby/moby#40307

Swarm Jobs were initially implemented in Docker Engine 20.10

Signed-off-by: ollypom <oppomeroy@gmail.com>
@netlify
Copy link

netlify bot commented Jan 4, 2021

✔️ Deploy preview for docsdocker ready!

🔨 Explore the source changes: 9234980

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docsdocker/deploys/6005f3203c85a400075ea66d

😎 Browse the preview: https://deploy-preview-12037--docsdocker.netlify.app

@usha-mandya
Copy link
Member

Thanks @ollypom.

@thaJeztah Could you PTAL?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf. Started reviewing this, but didn't manage to finish (wanted to have another look to see what it looks like with my suggestions, but let me submit what I have so far 😓)

engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
engine/swarm/swarm-jobs.md Outdated Show resolved Hide resolved
Signed-off-by: ollypom <oppomeroy@gmail.com>
@ollypom
Copy link
Contributor Author

ollypom commented Jan 18, 2021

Thanks @thaJeztah 😄 I've incorporated your feedback in the latest commit.

@Felixoid
Copy link

Is there still something blocking the PR from merge?

@DakotaNelson
Copy link

Hey @thaJeztah - hate to bug you but it would be awesome if you were able to take another pass at this. Would help a lot of people (including me!) use this functionality thanks to better docs.

The code was released in early December 2020 but in my searching for how to do this, it took quite a while to realize it's actually supported in swarm natively and just undocumented. ☹️

@hertzg
Copy link

hertzg commented Mar 23, 2022

A humble ping @thaJeztah would be awesome if we could get this documented and rolling.

Also should we have a separate pr for documenting global-job and repliated-job modes for docker-compose?

@craig-osterhout craig-osterhout added the area/swarm Issue affects swarm and clustering functionality of docker label Aug 4, 2022
@usha-mandya usha-mandya reopened this Oct 21, 2022
@usha-mandya
Copy link
Member

Close and reopen PR to trigger build checks

@hertzg
Copy link

hertzg commented Nov 1, 2022

@usha-mandya Seems like there's some MDL issues and a broken link (htmlproffer) reported by the checks

@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/swarm Issue affects swarm and clustering functionality of docker lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants