Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildx reference docs #12092

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 13, 2021

relates to docker/buildx#91 and docker/buildx#506

This brings in more detailed command-line reference for the buildx subcommands; some enhancements were made to the template to add support for linking flag descriptions to a section on the page (or possibly an URL).

For example; the flag names in the "options" table on this page is now clickable; https://deploy-preview-12092--docsdocker.netlify.app/engine/reference/commandline/buildx_bake/#options

Screenshot 2021-03-26 at 16 58 37

Which allows users to click to scroll to the relevant section on the page, for example, the section describing the --progress flag; https://deploy-preview-12092--docsdocker.netlify.app/engine/reference/commandline/buildx_bake/#progress

@netlify
Copy link

netlify bot commented Jan 13, 2021

Deploy preview for docsdocker ready!

Built with commit 19ede73

https://deploy-preview-12092--docsdocker.netlify.app

@thaJeztah thaJeztah force-pushed the buildx_reference branch 5 times, most recently from 5ac0cef to 91e6838 Compare March 26, 2021 15:53
@thaJeztah thaJeztah marked this pull request as ready for review March 26, 2021 16:03
@thaJeztah
Copy link
Member Author

@thaJeztah
Copy link
Member Author

Pushed one more commit to update the "working with buildx" page

@thaJeztah thaJeztah force-pushed the buildx_reference branch 3 times, most recently from 7e8f1f4 to c9aaaf0 Compare March 27, 2021 00:41
@thaJeztah
Copy link
Member Author

also added the missing pages for docker buildx install and docker buildx uninstall (these commands are hidden, but were referenced in the "work with buildx" introduction

@@ -33,6 +45,7 @@ options:
- option: driver
value_type: string
description: 'Driver to use (available: [])'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a backtick here

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is coming from the generated code, and on the command-line we don't print backtics, so I'll need to have a look at this separately (we have the same issue on some of our other reference docs pages)

@usha-mandya
Copy link
Member

@thaJeztah Thanks for the PR. Looks good overall. Left some minor suggestions.

The YAML files now support a new "details_url" property for flags, which
can be set if there's an anchor on the same page, or an URL where to
find a detailed description of the flag (Currently only anchors are used).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
these commands are hidden in the cli, but functional, and mentioned
in the "working with buildx" introduction.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- remove the experimental banner
- moved the "install as default builder section under the install
  section
- wrapped lines to be ~80 chars
- created some links to reference pages

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@usha-mandya I addressed your comments; I have a PR pending upstream with those changes (docker/buildx#583) but already regenerated the yaml files with those applied and updated this PR (so should be ready for review/merge)

@thaJeztah thaJeztah added the area/build Relates to Dockerfiles or docker build command label Apr 7, 2021
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @thaJeztah

@usha-mandya usha-mandya merged commit 808f73d into docker:master Apr 7, 2021
@thaJeztah thaJeztah deleted the buildx_reference branch April 7, 2021 14:35
@thaJeztah
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants