-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code example for pre-existing network #14851
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dockertopia Thank you for your review. I don't see any reasoning why #13958 was made. It appears to be incorrect for me. My suggested change was previously applied here: #6124 Please see the related comment: docker-archive/compose-cli#1856 (comment) |
Hmm.. yes, #13958 looks a bit odd indeed; I think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regarding the Compose specification
@grappler Thanks for catching this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grappler. That was a good catch. Felt compelled to double check based on previous change to the file.
Proposed changes
Update the code example to match the new syntax.
Related issues (optional)
Fixes #14683