Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: remove CAP_PERFMON, CAP_BPF, CAP_CHECKPOINT_RESTORE from relnotes #15050

Merged
merged 1 commit into from Jul 6, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 4, 2022

These capabilities were reverted in moby/moby@a38b96b (moby/moby#41563),
because the version of containerd and runc that shipped together with
docker 20.10.0 did not support them.

Current versions of containerd and runc support these, so possibly we can
include them again in a patch release, but otherwise support will come in
the next (22.06) release of docker engine.

Proposed changes

Related issues (optional)

…otes

These capabilities were reverted in moby/moby@a38b96b,
because the version of containerd and runc that shipped together with
docker 20.10.0 did not support them.

Current versions of containerd and runc support these, so possibly we can
include them again in a patch release, but otherwise support will come in
the next (22.06) release of docker engine.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label Jul 4, 2022
@netlify
Copy link

netlify bot commented Jul 4, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 11ceee2
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62c2e0ebc00fd90008576019
😎 Deploy Preview https://deploy-preview-15050--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@dockertopia dockertopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My interpretation was you are repackaging the release assets for 20.10.0 reflecting mentioned reversal. If this is the case, is adding this line amidst the regular RNs of that release the best option?
What do you think of adding this line as a note (with a date, that is going to be posterior to the release date) at the top of the page?

@thaJeztah
Copy link
Member Author

No, this is deleting an entry from the release notes, because the new feature was reverted/disabled before the 20.10.0 release, so didn't make it into the release, and should not have been included in the changelog

Copy link
Contributor

@dockertopia dockertopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockertopia dockertopia merged commit 3358614 into docker:master Jul 6, 2022
@thaJeztah thaJeztah deleted the amend_release_notes branch July 6, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAP_PERFMON works in runc but not docker Support for CAP_PERFMON, CAP_BPF, and CAP_CHECKPOINT_RESTORE
2 participants