Document legacy build vs BuildKit differences #15477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
craig-osterhout
added
the
area/build
|
@craig-osterhout When will this be reviewed and merged? |
|
@andreisilviudragnea Could you rebase the PR? |
andreisilviudragnea
force-pushed
the
moby-buildkit-diffs
branch
from
06c9675
to
d748338
Compare
andreisilviudragnea
requested review from
crazy-max,
usha-mandya,
jedevc and
dvdksn
as code owners
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@usha-mandya Done. |
|
Thank you @andreisilviudragnea. One of our team members will take a look and get back to you. |
dvdksn
reviewed
Oct 21, 2022
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
andreisilviudragnea
force-pushed
the
moby-buildkit-diffs
branch
from
1956bc6
to
017cc33
Compare
andreisilviudragnea
changed the title
andreisilviudragnea
requested review from
dvdksn
and removed request for
crazy-max,
jedevc and
usha-mandya
dvdksn
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I documented how legacy engine executes all stages of a multi-stage Dockerfile from the beginning of the Dockerfile up to the target stage, even if target stage does not depend on some intermediate stages. When BuildKit is enabled, this (possible bug) does not happen and only transitive dependency stages of the target stage get executed.
I also documented that BuildKit is not enabled by default on all platforms (it is on macOS, but not on Linux) and that multi-stage builds should always be executed with BuildKit enabled in order to avoid the problem described above.
Related issues
Fixes #12231