Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildx setup instructions to use install: true #18801

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Nov 28, 2023

Proposed changes

Currently, install defaults to false.

Setting install to true makes docker build use the new builder. I think this is probably the behavior most people want.

Currently, `install` defaults to false.

Setting `install` to true makes `docker build` use the new builder.
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e29a58c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6566732ffe25f9000893db66
😎 Deploy Preview https://deploy-preview-18801--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Nov 28, 2023
@nicks
Copy link
Contributor Author

nicks commented Nov 28, 2023

@crazy-max i also wonder if it makes sense to change the defaults on the upstream action? but i guess that's a separate discussion.

@crazy-max
Copy link
Member

I don't think this is necessary, since Docker 23 docker build defaults to docker buildx build, see https://docs.docker.com/build/architecture/.

@crazy-max i also wonder if it makes sense to change the defaults on the upstream action? but i guess that's a separate discussion.

In contrary I think we should remove the install input in the setup-buildx-action as it doesn't make a lot of sense anymore.

@nicks
Copy link
Contributor Author

nicks commented Nov 28, 2023

Hmmm...in my tests, it's still necessary. I'll send you what some logs off-list

@crazy-max
Copy link
Member

Hmmm...in my tests, it's still necessary. I'll send you what some logs off-list

Oh right I think I understand why now:

docker build use the new builder.

This is related to docker/cli#3676

@dvdksn dvdksn merged commit e75dfd5 into main Nov 29, 2023
9 checks passed
@dvdksn dvdksn deleted the nicks-patch-1 branch June 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants