Fix list like environments attribute #19348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envrionments attribute is a mapping not a list See caused confusion docker/compose#1171 (comment)
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
area/compose
|
It should support both?; https://docs.docker.com/compose/compose-file/05-services/#environment 
|
dvdksn
reviewed
Feb 8, 2024
Comment on lines
67
to
+68
| environment: | ||
| - DEBUG=${DEBUG} | ||
| DEBUG=${DEBUG} |
There was a problem hiding this comment.
This doesn't look valid. There's no colon delimiter for the map key/value, so this would be interpreted as a string.
Thanks! My bad, I blindly believed
|
|
Added my observation/question rather here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
envrionmentsattribute is a mapping not a listRelated issues (optional)
See caused confusion docker/compose#1171 (comment)