This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Add "SecurityOptions" in Info. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -243,6 +243,7 @@ type Info struct { | |||
| ServerVersion string | |||
| ClusterStore string | |||
| ClusterAdvertise string | |||
| SecurityOptions string | |||
There was a problem hiding this comment.
should we make this a []string? I think that'd be better for the API (and similar to, e.g. how we have a list of installed plugins;
Lines 248 to 257 in 0ec73ff
There was a problem hiding this comment.
@thaJeztah Yes []string is definitely better than a space separated string and easy to process. Let me update the pull request. Thanks!
This PR tries to add SecurityOptions field in Info so that security options such as apparmor, seccomp, or selinux could be displayed by `docker info`. Detailed discussion could be found in: moby/moby#20909 moby/moby#21172 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
@thaJeztah Just updated the pull request to change to |
|
LGTM |
1 similar comment
|
LGTM |
|
Please, do not merge this PR yet. We're waiting for a release cut in docker/docker before moving this forward. |
calavera
added
status/wait-until-release-freeze
and removed
status/wait-until-release-freeze
labels
|
We already have a tag a frozen branches for both projects. Merging this in 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add SecurityOptions field in Info so that security options such as apparmor, seccomp, or selinux could be displayed by
docker info.Detailed discussion could be found in:
moby/moby#20909
moby/moby#21172
cc @justincormack @calavera @thaJeztah
Signed-off-by: Yong Tang yong.tang.github@outlook.com