This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Add config parameter to change per-container stop timeout during daemon shutdown #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on shutdown This fix tries to add config paramter to change per-contaienr stop timeout during the daemon shutdown. As the part of the update, this fix also changes `docker restart` and `docker stop` so that if `--time` is not specified, then the default stop timeout (10s) will be used. This fix is related to moby/moby#22566 moby/moby#22471 Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
LGTM |
1 similar comment
|
LGTM |
|
"Make the zero-value useful" Could we please stop adding needless pointer values everywhere? This is getting tiresome. 1ns is just as good as zero and doesn't cause all kinds of havoc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to add config paramter to change per-contaienr stop timeout during the daemon shutdown. As the part of the update, this fix also changes
docker restartanddocker stopso that if--timeis not specified, then the default stop timeout (10s) will be used.This fix is related to
moby/moby#22566
moby/moby#22471
Signed-off-by: Yong Tang yong.tang.github@outlook.com