Remove SwarmInspect method. #318
Conversation
SwarmInspect information are redundant with Info. The API won't serve `GET /swarm` anymore so removing the client method too. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
added
status/2-code-review
status/1-design-review
and removed
status/0-triage
status/2-code-review
labels
|
LGTM |
|
LGTM |
| @@ -120,6 +120,8 @@ type Info struct { | |||
| Nodes int | |||
| Managers int | |||
| CACertHash string | |||
|
|
|||
| Cluster Swarm | |||
There was a problem hiding this comment.
// Cluster contains data about the swarm to which this node has joined.
|
Are we making a mistake by creating a compound data structures? The main issue here is that we end up with an imbalance between the object that is modified and how to read the results of that modification. |
Yeah, I do agree on that one, it feels a little weird to update swarm properties via Maybe we should keep swarm inspect and endpoint and just make |
|
This tableflip is not specific to this issue, I'm just tired with all the back and forths that's all. Feel free to ignore it. |
|
@tiborvass This is not back and forth. This is CLI decisions being used to make thoughtless changes to the API. We have a deep design problem that our API and CLI are over-coupled. I'm fine with the CLI decision. It is a good one. I just don't understand why we think that means we have to delete this endpoint on the API. Go ahead and merge this. |
|
Hey, side note - I think we need to be able to inspect in order to update (which we use for swarm config, such as join secret etc) |
SwarmInspect information are redundant with Info. The API won't serve
GET /swarmanymore so removing the client method too. 👼Related PR moby/moby#24492
/cc @thaJeztah @icecrime @tiborvass @aluzzardi @stevvooe
🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm