This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Fix CI for go1.7 #382
Merged
Fix CI for go1.7 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govet detected a case where we copy tls.Config although the var contains mutexes. This is fixed in go1.8 with a stdlib Clone method. Temporarily add a local copy of that function until we can move to go1.8 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
So this will not work for Go1.6 and under, I guess it's fine. LGTM |
|
Is this really how |
|
@tiborvass I can make a go1.6 function as well if you think it's important. We can't reuse the same function though because new keys were added. |
|
Fair enough: |
|
LGTM |
jarondl
added a commit
to jarondl/telegraf
that referenced
this pull request
Feb 15, 2017
The docker engine-api package we use needs golang 1.7+, see: docker/engine-api#382 (comment) So telegraf won't compile without 1.7
2 tasks
sparrc
pushed a commit
to influxdata/telegraf
that referenced
this pull request
Feb 15, 2017
The docker engine-api package we use needs golang 1.7+, see: docker/engine-api#382 (comment) So telegraf won't compile without 1.7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govet detected a case where we copy tls.Config although
the var contains mutexes. This is fixed in go1.8 with a
stdlib Clone method. Temporarily add a local copy of that
function until we can move to go1.8
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com