This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03] Keep but deprecate registry v2 schema1 logic and revert to libtrust-key-based engine ID #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 18, 2019 18:54
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 0811297) Signed-off-by: Tibor Vass <tibor@docker.com>
This reverts commit 98fc091 in order to keep registry v2 schema1 handling and libtrust-key-based engine ID. Because registry v2 schema1 was not officially deprecated and registries are still relying on it, this patch puts its logic back. However, registry v1 relics are not added back since v1 logic has been removed a while ago. This also fixes an engine upgrade issue in a swarm cluster. It was relying on the Engine ID to be the same upon upgrade, but the mentioned commit modified the logic to use UUID and from a different file. Since the libtrust key is always needed to support v2 schema1 pushes, that the old engine ID is based on the libtrust key, and that the engine ID needs to be conserved across upgrades, adding a UUID-based engine ID logic seems to add more complexity than it solves the problems. Hence reverting the engine ID changes as well. Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit f695e98) Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 53dad9f) Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit f923321) Signed-off-by: Tibor Vass <tibor@docker.com>
This will add a warning log in the daemon, and will send the message to be displayed by the CLI. Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit d35f8f4) Signed-off-by: Tibor Vass <tibor@docker.com>
…revert Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 3f1cdd5) Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
19.03-revert-remove-legacy-registry
branch
from
0a272ba
to
e61e107
Compare
tiborvass
changed the title
|
@andrewhsu @thaJeztah updated with clean cherry-picks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of moby#39365