Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] For ipvlan tests check that the ipvlan module is enabled #288

Merged
merged 1 commit into from Sep 23, 2019
Merged

[18.09 backport] For ipvlan tests check that the ipvlan module is enabled #288

merged 1 commit into from Sep 23, 2019

Conversation

thaJeztah
Copy link
Member

backport of moby#39358 for 18.09

@kolyshkin @jim-docker @thaJeztah
For ipvlan tests check that the ipvlan module is enabled (instead of …
d949c67 
…just ensuring the kernel version is greater than 4.2)

Co-Authored-By: Jim Ehrismann <jim-docker@users.noreply.github.com>
Co-Authored-By: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com>
Signed-off-by: Jim Ehrismann <jim.ehrismann@docker.com>
(cherry picked from commit a77e147)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.7 milestone Jun 24, 2019
@thaJeztah thaJeztah requested a review from kolyshkin June 24, 2019 22:43
kolyshkin
kolyshkin approved these changes Jun 24, 2019
View reviewed changes
Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link

I see it skipping the tests for experimental run:

00:21:21.035 === RUN   TestDockerNetworkIpvlanPersistance
00:21:21.049 --- SKIP: TestDockerNetworkIpvlanPersistance (0.01s)
00:21:21.050 	ipvlan_test.go:27: !ipvlanKernelSupport(t): Kernel doesn't support ipvlan
00:21:21.050 === RUN   TestDockerNetworkIpvlan
00:21:21.051 --- SKIP: TestDockerNetworkIpvlan (0.00s)
00:21:21.051 	ipvlan_test.go:55: !ipvlanKernelSupport(t): Kernel doesn't support ipvlan
00:21:21.052 PASS

@andrewhsu andrewhsu modified the milestones: 18.09.7, 18.09.8 Jun 27, 2019
@thaJeztah thaJeztah modified the milestones: 18.09.8, 18.09.9 Jul 18, 2019
@thaJeztah thaJeztah modified the milestones: 18.09.9, 18.09.10 Aug 30, 2019
@andrewhsu andrewhsu merged commit 911e3c7 into docker:18.09 Sep 23, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_testForIpvlan branch September 23, 2019 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolyshkin kolyshkin kolyshkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.09.10
3 participants
@thaJeztah @andrewhsu @kolyshkin