Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] bump gorilla/mux v1.7.2 #289

Merged
merged 1 commit into from Sep 24, 2019

Conversation

thaJeztah
Copy link
Member

backport of moby#39381 for 19.03
cli bump is in docker/cli#1958

full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

@thaJeztah
Copy link
Member Author

Rebased to run the new CI (old CI was green)

@thaJeztah
Copy link
Member Author

ping @kolyshkin PTAL

@thaJeztah thaJeztah modified the milestones: 19.03.2, 19.03.3 Aug 30, 2019
@thaJeztah thaJeztah changed the title [19.03 backport] bump gorilla/mux v1.7.2 [WIP][19.03 backport] bump gorilla/mux v1.7.2 Sep 6, 2019
@thaJeztah thaJeztah force-pushed the 19.03_backport_bump_gorilla_mux branch from 5e7e724 to 0571dd3 Compare September 6, 2019 21:42
@thaJeztah
Copy link
Member Author

moby#39381 was merged, so removing "WIP"

@thaJeztah thaJeztah changed the title [WIP][19.03 backport] bump gorilla/mux v1.7.2 [19.03 backport] bump gorilla/mux v1.7.2 Sep 6, 2019
@thaJeztah thaJeztah force-pushed the 19.03_backport_bump_gorilla_mux branch from 0571dd3 to dc30868 Compare September 12, 2019 08:24
@thaJeztah
Copy link
Member Author

This is all green, except for PowerPC, which got killed by Jenkins (perhaps OOM)

PTAL

full diff: gorilla/mux@v1.7.0...v1.7.2

includes:

 - gorilla/mux#457 adding Router.Name to create new Route
 - gorilla/mux#447 host:port matching does not require a :port to be specified

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 25b451e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 19.03_backport_bump_gorilla_mux branch from dc30868 to 486953e Compare September 20, 2019 17:07
Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 0ff52c2 into docker:19.03 Sep 24, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_bump_gorilla_mux branch September 24, 2019 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants