[19.03 backport] Fix regression in handling of NotFound err during startup ENGCORE-929

[thaJeztah]

backport of moby#39703 for 19.03

Signed-off-by: Deep Debroy ddebroy@docker.com
(cherry picked from commit 4d5b626)
Signed-off-by: Sebastiaan van Stijn github@gone.nl

- What I did
Address a regression during daemon startup introduced in moby#38931.

fixes moby#39623
fixes moby#39742
fixes docker/for-win#4463
fixes microsoft/navcontainerhelper#548

- How I did it
Added (back) proper handling of NotFound err

- How to verify it
Start a container in Windows like:

docker run -d --restart always --name testcontainer --network nat -p 8080:80 mcr.microsoft.com/windows/servercore:ltsc2019 ping -t 127.0.0.1

and Restart-Computer.
After reboot, make sure container comes back up properly and is not a zombie.

- Description for the changelog
Fix regression in reboot of Windows daemon

- A picture of a cute animal (not mandatory but encouraged)

[thaJeztah]

@ddebroy @crosbymichael @kolyshkin ptal

[ddebroy]

LGTM

[crosbymichael]

LGTM Michael Crosby

…

On Aug 8, 2019, at 8:20 PM, Deep Debroy ***@***.***> wrote: LGTM — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kolyshkin]

LGTM

[thaJeztah]

RS1 failure can be fixed by moby#39168

which wasn't backported yet

02:24:29 --- FAIL: TestClientWithRequestTimeout (0.00s)
02:24:29     client_test.go:259: assertion failed: 
02:24:29         --- context.DeadlineExceeded
02:24:29         +++ err
02:24:29         :
02:24:29         	-: context.deadlineExceededError{}
02:24:29         	+: &net.OpError{Op: "dial", Net: "tcp", Addr: s"127.0.0.1:49294", Err: &poll.TimeoutError{}}

[freddydk]

Any information on when we will see this released?
Azure VMs using image Windows Server 2019 with Containers is now including 19.03.1 and all containers are left as living dead after reboot (which happens frequently)

[thaJeztah]

19.03.2 will be released next week and include this patch

[freddydk]

Great, will there be a docker desktop 2.1.0.2 as well then?
Will have to reach out to Azure team to update the server images asap.

[thaJeztah]

Desktop releases will be released in tandem, yes

[cpuguy83]

Doesn't seem like this commit is in the 19.03.2 tag.

[thaJeztah]

@cpuguy83 it looks to be in there?

this repo; https://github.com/docker/engine/blob/v19.03.2/daemon/daemon.go#L338

docker/docker-ce repo: https://github.com/docker/docker-ce/blob/v19.03.2/components/engine/daemon/daemon.go#L338

[cpuguy83]

Ah, GH is not reporting it in the tag for some reason.
I did a compare and indeed it seems like it is there.