Update tutorials to use API client libs, and update them to base them on a React frontend #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gtardif
commented
Mar 29, 2022
gtardif
commented
- Move React tutorial as the second one, before Docker CLI commands and extensions with backend
- change Docker CLI tutorial and backend tutorial to be based on React frontend and use client API libs
…ker CLI tutarial to use react and import api-client Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
fbricon
reviewed
Mar 29, 2022
| @@ -0,0 +1,3 @@ | |||
| interface Window { | |||
| ddClient: any; | |||
There was a problem hiding this comment.
what's the plan for providing a complete type definition for ddClient?
There was a problem hiding this comment.
Thx, I think we can remove this any definition (replaced by importing a typescript library that has all type definition), also mentioned in this PR. I'll include removing this global that should not be needed anymore
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
| @@ -15,17 +15,36 @@ In the `minimal-backend` sample folder, you can find a ready-to-go example. It r | |||
| ├── Makefile | |||
There was a problem hiding this comment.
As the order of the tutorials has changed, this tutorial is the last one now. Therefore, at the very bottom of this file, I'd remove the following:
## What's next?
See the next [tutorial](../react-extension) to create a ReactJS-based extension.
| @@ -15,14 +15,45 @@ In the `minimal-docker-cli` sample folder, you can find a ready-to-go example th | |||
| . | |||
There was a problem hiding this comment.
At the end of this page, update the What's next? link to point to the next tutorial in the new order.
…rder Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.