New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/proc/meminfo
no longer reports Hugepagesize
in 4.26.1
#7117
Comments
Duplicate of #7115 |
Actually, when we removed Huge Pages, we probably forgot to also remove Transparent Huge Pages. Until we find how to re-enable HP, I'll remove THP, this should fix the inconsistency you see, @joelrbrandt. |
@dgageot thanks for looking into this! Apologies, but I'm not sure what you're looking for in repro steps beyond what I put in the issue description. The issue we're having is that oneTBB throws this assert when it tries to allocate memory: The reason it throws that assert is because:
It gets a I guess the two Docker commands to demonstrate this behavior would be:
Anyway, your theory about removing THP should indeed fix this inconsistency (assuming the first command above no longer produces a grep match). LMK if I can help further! |
Thanks a lot for all the details! |
Hi everyone! Turns out we found how to re-enable Huge Pages, keep Transparent Huge Pages and still fix the php issue. This should ship in Docker Desktop 4.27. |
Woohoo! Thanks for the work on this, and the update, @dgageot ! |
@joelrbrandt Could you test Docker Desktop 4.27 and close this issue if it's fixed? |
@dgageot confirming that I was able to repro the problem in 4.26.1 using our latest code (I hadn't tried in awhile), and that I was not able to repro on 4.27.0. It's fixed 🙌 Thank you for your attention to this issue, and for closing the loop when it was fixed! Closing this issue! |
Description
Starting with Docker Desktop for Mac 4.26.1,
/proc/meminfo
no longer reportsHugepagesize
.I have only tested versions 4.25.2 and 4.26.1. It is reported in 4.25.2, and is not in 4.26.1
This value is read by oneTBB here, and when it can't be read, it results in this assert:
Output from an
ubuntu:latest
container in 4.25.2 (correct output):Output from an
ubuntu:latest
container in 4.26.1 (problematic output):Reproduce
docker run --rm ubuntu cat /proc/meminfo
Hugepagesize
entry in the outputExpected behavior
There should be a
Hugepagesize
entrydocker version
Client: Cloud integration: v1.0.35+desktop.5 Version: 24.0.7 API version: 1.43 Go version: go1.20.10 Git commit: afdd53b Built: Thu Oct 26 09:04:20 2023 OS/Arch: darwin/arm64 Context: desktop-linux Server: Docker Desktop 4.26.1 (131620) Engine: Version: 24.0.7 API version: 1.43 (minimum version 1.12) Go version: go1.20.10 Git commit: 311b9ff Built: Thu Oct 26 09:08:15 2023 OS/Arch: linux/arm64 Experimental: false containerd: Version: 1.6.25 GitCommit: d8f198a4ed8892c764191ef7b3b06d8a2eeb5c7f runc: Version: 1.1.10 GitCommit: v1.1.10-0-g18a0cb0 docker-init: Version: 0.19.0 GitCommit: de40ad0
docker info
Diagnostics ID
CB57EE1C-B6BA-4A90-8B85-A1525694B3FF/20231216175834
Additional Info
No response
The text was updated successfully, but these errors were encountered: