Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Please bundle a newer build of docker-credential-ecr-login #10105

Closed
3 of 5 tasks
TBBle opened this issue Jan 15, 2021 · 8 comments
Closed
3 of 5 tasks

Comments

@TBBle
Copy link

TBBle commented Jan 15, 2021

  • I have tried with the latest version of Docker Desktop
  • I have tried disabling enabled experimental features
  • I have uploaded Diagnostics
  • Diagnostics ID:
  • I am using the Docker WSL2 Backend
  • I am using the Docker Hyper-V Backend

Actual behavior

The docker-credential-ecr-login.exe bundled with Docker Desktop is 0.4.0, and predates awslabs/amazon-ecr-credential-helper#201, which means that using it with, e.g., a credentials_process fails unless env-vars are set.

See awslabs/amazon-ecr-credential-helper#232 for details and the workaround.

Hoped-for behaviour

The docker-credential-ecr-login.exe bundled with Docker Desktop is built from newer source than 0.4.0, and includes awslabs/amazon-ecr-credential-helper#201, hence removing the need to worry about setting env-vars.

There hasn't been an upstream release of this utility since 0.4.0, but not much has changed since. In fact, this is the only changelog-worth feature since then. So I'm hoping just building the latest master tree is fine.

Otherwise, this can wait for an 0.5.0 release, whenever that happens: https://github.com/awslabs/amazon-ecr-credential-helper/milestone/3

@stephen-turner
Copy link
Contributor

Thanks, @TBBle. We do generally wait for official releases of our upstream components: do you have any idea when the 0.5.0 (or 0.4.1?) release will be made?

@TBBle
Copy link
Author

TBBle commented Jan 16, 2021

I don't know, it's been a long time since the last release (January 2020) so I thought the project was idled. However, there was some renewed activity from a few maintainers in December, including creating an 0.5.0 milestone albeit without a target date.

Perhaps @samuelkarp or @kzys can clarify the current and intended state?

@TBBle
Copy link
Author

TBBle commented Feb 20, 2021

Amazon ECR Credential Helper - Release v0.5.0 has been released, so this should be unblocked now.

@stephen-turner
Copy link
Contributor

Great, thanks for letting us know.

@stephen-turner
Copy link
Contributor

We've bumped it in our code, it will be in the next release.

@docker-robott
Copy link
Collaborator

Issues go stale after 90 days of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30 days of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@TBBle
Copy link
Author

TBBle commented May 23, 2021

Ooops, forgot to close this. docker-credential-ecr-login 0.5.0 was included in Docker Desktop 3.2.0.

@TBBle TBBle closed this as completed May 23, 2021
@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants