Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential helpers are used even if they are not configured #6043

Open
philippe-granet opened this issue Mar 16, 2020 · 6 comments
Open

Credential helpers are used even if they are not configured #6043

philippe-granet opened this issue Mar 16, 2020 · 6 comments

Comments

@philippe-granet
Copy link

[ X ] I have tried with the latest version of my channel (Stable or Edge)

Expected behavior

Docker should keep the config.json file untouched on every startup (esp. not insert/modify credStore value).

Actual behavior

On every startup, Docker modifies the config.json file on Windows, adding "credsStore":"desktop", which ultimatively leads to a situation in which it is not using the credentials stored in the config.json file in base64 encoding. In our use case, this is needed. In #1359, a checkbox has been introduced for Docker for Mac ("Securely store Docker logins in macOS keychain") to work around this issue. A solution would be to also introduce it for Docker for Windows. Alternatively, an option "credsStore":"none" would be an option which is persisted.

@philippe-granet
Copy link
Author

Create new issue since #5020 is closed

@docker-robott
Copy link
Collaborator

Issues go stale after 90 days of inactivity.
Mark the issue as fresh with /remove-lifecycle stale comment.
Stale issues will be closed after an additional 30 days of inactivity.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle stale

@pleonex
Copy link

pleonex commented Jun 14, 2020

/lifecycle frozen /remove-lifecycle stale

@philippe-granet
Copy link
Author

Why frozen? Bug is here

@pleonex
Copy link

pleonex commented Jun 14, 2020

Frozen means that it won't close this bug report automatically right? I did it to prevent the bot closing it without an answer from the docker dev team.

@0x53A
Copy link

0x53A commented May 12, 2021

The windows credentials store does not work for us, because our build script runs elevated: docker/cli#2682 (comment)

It turns out you cannot Docker login via an elevated shell depending on your environment as it appears the credentials don't get passed through

It works when I manually remove the credStore from my config.json file, but on the next docker restart docker will replace it with desktop again.

Please either fix the bug that elevated shells can't login, or that credStore gets reset. Either would be fine, preferably both ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants